Skip to content

[Kibana] Add missing "basepath" variable in Kibana integration settings#7365

Merged
crespocarlos merged 1 commit intoelastic:mainfrom
jennypavlova:7359-kibana-missing-basepath-variable-in-kibana-integration-settings
Aug 15, 2023
Merged

[Kibana] Add missing "basepath" variable in Kibana integration settings#7365
crespocarlos merged 1 commit intoelastic:mainfrom
jennypavlova:7359-kibana-missing-basepath-variable-in-kibana-integration-settings

Conversation

@jennypavlova
Copy link
Copy Markdown
Member

@jennypavlova jennypavlova commented Aug 11, 2023 •
edited
Loading

What does this PR do?

This PR adds the basepath setting inside the Kibana integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-08-11 at 16-53-33 Add integration - Kibana - Integrations - Elastic

@jennypavlova jennypavlova added the bugfix Pull request that fixes a bug issue label Aug 11, 2023
@jennypavlova jennypavlova requested a review from a team as a code owner August 11, 2023 15:10
@jennypavlova jennypavlova added the Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services label Aug 11, 2023
@jennypavlova jennypavlova self-assigned this Aug 11, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-11T15:10:35.915+0000

  • Duration: 31 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 1
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 11, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (4/4) 💚 5.556
Classes 100.0% (4/4) 💚 5.556
Methods 95.238% (40/42) 👍 9.285
Lines 87.234% (82/94) 👍 1.21
Conditionals 100.0% (0/0) 💚

crespocarlos
crespocarlos approved these changes Aug 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crespocarlos crespocarlos merged commit c7a3a63 into elastic:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees

@jennypavlova jennypavlova

Labels

bugfix Pull request that fixes a bug issue Integration:kibana Kibana Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Kibana] Missing "basepath" variable in Kibana integration settings

4 participants

@jennypavlova @elasticmachine @crespocarlos @andrewkroh